[webkit-reviews] review granted: [Bug 121613] [GTK] Fix some small style issues in the bindings : [Attachment 212086] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 121613: [GTK] Fix some small style issues in the bindings
https://bugs.webkit.org/show_bug.cgi?id=121613

Attachment 212086: Patch
https://bugs.webkit.org/attachment.cgi?id=212086&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212086&action=review


Excellent!

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:556
> +    my %parameterSpecOptions = ("int" =>	[ "G_MININT", "G_MAXINT", "0"
],
> +				   "int8" =>	[ "G_MININT8", "G_MAXINT8", "0"
],
> +				   "boolean" => [ "FALSE" ],
> +				   "float" =>	[ "-G_MAXFLOAT", "G_MAXFLOAT",
"0" ],
> +				   "double" =>	[ "-G_MAXDOUBLE",
"G_MAXDOUBLE", "0" ],
> +				   "uint64" =>	[ "0", "G_MAXUINT64", "0" ],
> +				   "long" =>	[ "G_MINLONG", "G_MAXLONG", "0"
],
> +				   "int64" =>	[ "G_MININT64", "G_MAXINT64",
"0" ],
> +				   "ulong" =>	[ "0", "G_MAXULONG", "0" ],
> +				   "uint" =>	[ "0", "G_MAXUINT", "0" ],
> +				   "uint8" =>	[ "0", "G_MAXUINT8", "0" ],
> +				   "ushort" =>	[ "0", "G_MAXUINT16", "0" ],
> +				   "uchar" =>	[ "G_MININT8", "G_MAXINT8", "0"
],
> +				   "char" =>	[ "0", "G_MAXUINT8", "0" ],
> +				   "string" =>	[ '""', ],
> +				   "object" =>	[
"WEBKIT_TYPE_DOM_${ucPropGType}" ]);
> +

:-)