[webkit-reviews] review denied: [Bug 121589] Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places : [Attachment 212035] Cleanup

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 121589: Remove superfluous CSSLinearTimingFunctionValue and use switch on
TimingFunction::type() in more places
https://bugs.webkit.org/show_bug.cgi?id=121589

Attachment 212035: Cleanup
https://bugs.webkit.org/attachment.cgi?id=212035&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212035&action=review


> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1253
> +	   {
> +	       const StepsTimingFunction* stepsTimingFunction =
static_cast<const StepsTimingFunction*>(timingFunction);
> +	       return
CSSStepsTimingFunctionValue::create(stepsTimingFunction->numberOfSteps(),
stepsTimingFunction->stepAtStart());
> +	   }

This doesn't match our indentation style.

> Source/WebCore/page/animation/AnimationBase.cpp:605
> +	   {
> +	       const CubicBezierTimingFunction* function = static_cast<const
CubicBezierTimingFunction*>(tf);
> +	       return solveCubicBezierFunction(function->x1(), function->y1(),
function->x2(), function->y2(), fractionalTime, m_animation->duration());
> +	   }
> +    case TimingFunction::StepsFunction:
> +	   {
> +	       const StepsTimingFunction* stepsTimingFunction =
static_cast<const StepsTimingFunction*>(tf);
> +	       return solveStepsFunction(stepsTimingFunction->numberOfSteps(),
stepsTimingFunction->stepAtStart(), fractionalTime);
> +	   }

Ditto.