[webkit-reviews] review granted: [Bug 121584] MediaStream API: update NavigatorUserMediaError object to match spec : [Attachment 212064] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 19 10:38:25 PDT 2013
Dean Jackson <dino at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 121584: MediaStream API: update NavigatorUserMediaError object to match
spec
https://bugs.webkit.org/show_bug.cgi?id=121584
Attachment 212064: Updated patch
https://bugs.webkit.org/attachment.cgi?id=212064&action=review
------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212064&action=review
> Source/WebCore/Modules/mediastream/UserMediaRequest.h:68
> + virtual PassRefPtr<MediaConstraints> videoConstraints() const OVERRIDE;
Nit: two spaces before OVERRIDE
> Source/WebCore/Modules/mediastream/UserMediaRequest.h:69
> + virtual void didCompleteQuery(const MediaStreamSourceVector&
audioSources, const MediaStreamSourceVector& videoSources) OVERRIDE;
Here too.
More information about the webkit-reviews
mailing list