[webkit-reviews] review granted: [Bug 121596] [CTTE] RenderText is always anonymous or associated with Text node : [Attachment 212043] with updated mathml test results

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 121596: [CTTE] RenderText is always anonymous or associated with Text node
https://bugs.webkit.org/show_bug.cgi?id=121596

Attachment 212043: with updated mathml test results
https://bugs.webkit.org/attachment.cgi?id=212043&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212043&action=review


> Source/WebCore/rendering/RenderCounter.h:50
> +    RenderCounter(const CounterContent&);

explicit

> Source/WebCore/rendering/RenderQuote.h:39
> +    RenderQuote(QuoteType);

explicit

> Source/WebCore/rendering/RenderText.cpp:166
> -   
view().frameView().incrementVisuallyNonEmptyCharacterCount(m_text.length());
> +    if (textNode)
> +	  
view().frameView().incrementVisuallyNonEmptyCharacterCount(m_text.length());

This is so ugly. I wish we had alternate constructors for this kind of thing,
so view() is always guaranteed to work.