[webkit-reviews] review granted: [Bug 121583] Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in JavaScriptCore : [Attachment 212031] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 18 20:10:23 PDT 2013


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 121583: Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in
JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=121583

Attachment 212031: Patch
https://bugs.webkit.org/attachment.cgi?id=212031&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212031&action=review


> Source/JavaScriptCore/runtime/SymbolTable.h:477
> +    // FIXME: Should this take a std::unique_ptr<SlowArgument[]>&&.

It shouldn't.


More information about the webkit-reviews mailing list