[webkit-reviews] review granted: [Bug 121564] RefPtrHashMap should work with move only types : [Attachment 212010] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 121564: RefPtrHashMap should work with move only types
https://bugs.webkit.org/show_bug.cgi?id=121564

Attachment 212010: Patch
https://bugs.webkit.org/attachment.cgi?id=212010&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212010&action=review


r=me but dude...

> Source/JavaScriptCore/runtime/VM.cpp:495
> -    SourceProviderCacheMap::AddResult addResult =
sourceProviderCacheMap.add(sourceProvider, 0);
> +    SourceProviderCacheMap::AddResult addResult =
sourceProviderCacheMap.add(sourceProvider, nullptr);

auto

>> Source/WebCore/page/PageGroup.cpp:268
>> -	HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageNamespace> >::AddResult
result = m_transientLocalStorageMap.add(topOrigin, 0);
>> +	HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageNamespace>>::AddResult
result = m_transientLocalStorageMap.add(topOrigin, nullptr);
> 
> Missing spaces around >>  [whitespace/operators] [3]

auto

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:271
> -    HashMap<RefPtr<SecurityOrigin>, StorageArea*>::AddResult result =
m_storageAreaMap.add(securityOrigin, 0);
> +    HashMap<RefPtr<SecurityOrigin>, StorageArea*>::AddResult result =
m_storageAreaMap.add(securityOrigin, nullptr);

auto

>> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:354
>> +	HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageArea>>::AddResult result
= m_storageAreaMap.add(securityOrigin, nullptr);
> 
> Missing spaces around >>  [whitespace/operators] [3]

auto

>> Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp:88
>> -	HashMap<RefPtr<WebCore::SecurityOrigin>,
RefPtr<StorageAreaMap>>::AddResult result =
m_storageAreaMaps.add(securityOrigin.get(), 0);
>> +	HashMap<RefPtr<WebCore::SecurityOrigin>,
RefPtr<StorageAreaMap>>::AddResult result =
m_storageAreaMaps.add(securityOrigin.get(), nullptr);
> 
> Missing spaces around >>  [whitespace/operators] [3]

auto