[webkit-reviews] review denied: [Bug 119979] REGRESSION(r127163): Respect clearance set on ancestors when placing floats : [Attachment 211939] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 18 12:25:44 PDT 2013


Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 119979: REGRESSION(r127163): Respect clearance set on ancestors when
placing floats
https://bugs.webkit.org/show_bug.cgi?id=119979

Attachment 211939: Patch
https://bugs.webkit.org/attachment.cgi?id=211939&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r- 

I still think this is too late. The logicalTop() of the blocks just needs to be
set correctly. You're compensating after the fact for a mistake that was
already made earlier. I think the bug is just in collapseMargins somewhere.


More information about the webkit-reviews mailing list