[webkit-reviews] review granted: [Bug 121558] AX: Crash when trying to retrieve textual information for a heading after hiding it : [Attachment 212000] Patch proposal plus new Layout test

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 121558: AX: Crash when trying to retrieve textual information for a heading
after hiding it
https://bugs.webkit.org/show_bug.cgi?id=121558

Attachment 212000: Patch proposal plus new Layout test
https://bugs.webkit.org/attachment.cgi?id=212000&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212000&action=review


> LayoutTests/accessibility/heading-crash-after-hidden.html:24
> +    axHeading.helpText

you should use semicolons at end of lines

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1593
> +    Document* document = this->document();

I think we can cut this comment down to something like
"Update the document's layout now, so that if a TextIterator updates, it won't
invalidate our accessibility elements while iterating children"

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1596
> +    document->updateLayout();

we have a method already, we should probably use this one

void AccessibilityObject::updateBackingStore()
{
    // Updating the layout may delete this object.
    if (Document* document = this->document())
	document->updateLayoutIgnorePendingStylesheets();
}