[webkit-reviews] review granted: [Bug 121485] [Win] TestWebKitAPI does not compile. : [Attachment 211895] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted peavo at outlook.com's request for
review:
Bug 121485: [Win] TestWebKitAPI does not compile.
https://bugs.webkit.org/show_bug.cgi?id=121485

Attachment 211895: Patch
https://bugs.webkit.org/attachment.cgi?id=211895&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211895&action=review


I have a few questions, but I think this looks good.  I'll r+ it and trust that
you'll adjust things if you need to :-)

> Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:44
> +    auto hbmp = ::CreateDIBSection(0, &bitmapInfo, DIB_RGB_COLORS, 0, 0, 0);


Does this need to be cleaned up somewhere? I can't tell (with a few seconds
checking) whether we need to delete this GDI object.

Otherwise looks good to me.

> Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:48
> +    if (bitmapImageTest) {

I would prefer an early exit, but this is fine.

> Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:53
> +	   HBITMAP hBitmap = CreateBitmap(sz.width(), sz.height(), 1, 32,
bits);

Does this bitmap need to be destroyed to be correct in our GDI/memory handling?