[webkit-reviews] review denied: [Bug 119979] REGRESSION(r127163): Respect clearance set on ancestors when placing floats : [Attachment 211641] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 119979: REGRESSION(r127163): Respect clearance set on ancestors when
placing floats
https://bugs.webkit.org/show_bug.cgi?id=119979

Attachment 211641: Patch
https://bugs.webkit.org/attachment.cgi?id=211641&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211641&action=review


r-

> Source/WebCore/rendering/RenderBlockFlow.cpp:643
> +LayoutUnit RenderBlockFlow::marginOffsetForSelfCollapsingBlock()
> +{
> +    RenderBlock* current = this;
> +    while (current && current->isSelfCollapsingBlock()) {
> +	   if (current->style()->clear() && current->getClearDelta(current,
LayoutUnit()))
> +	       return current->collapsedMarginBeforeForChild(current);
> +	   current = current->containingBlock();
> +    }
> +    return LayoutUnit();
> +}

Doesn't look right that you're crossing objects that could be block formatting
contexts (e.g., positioned/floating ancestors). I still don't understand why
this information isn't coming down properly. Having to crawl up through
ancestors seems like the wrong approach.