[webkit-reviews] review granted: [Bug 121506] Add isTextOrBR() and use it : [Attachment 211923] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 17 11:05:43 PDT 2013


Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 121506: Add isTextOrBR() and use it
https://bugs.webkit.org/show_bug.cgi?id=121506

Attachment 211923: patch
https://bugs.webkit.org/attachment.cgi?id=211923&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211923&action=review


> Source/WebCore/rendering/RenderCounter.cpp:111
> -    if (object->isText() && !object->isBR())
> +    if (object->isText())

Aha! ;-)

> Source/WebCore/rendering/RenderTreeAsText.cpp:592
> -    if (o.isText() && !o.isBR()) {
> +    if (o.isText()) {

Glad this made you find these.


More information about the webkit-reviews mailing list