[webkit-reviews] review granted: [Bug 121495] [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix : [Attachment 211912] Patch proposal

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 121495: [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
https://bugs.webkit.org/show_bug.cgi?id=121495

Attachment 211912: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=211912&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211912&action=review


> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:909
> +    // We need to translate ATK values exposed for 'aria-sort' (e.g.
'asdending')

asdending > ascending

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:572
> +    // We need to translate ATK values exposed for 'aria-sort' (e.g.
'asdending')

ditto