[webkit-reviews] review granted: [Bug 121064] DFG should support Int48 for local variables : [Attachment 211866] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 121064: DFG should support Int48 for local variables
https://bugs.webkit.org/show_bug.cgi?id=121064

Attachment 211866: the patch
https://bugs.webkit.org/attachment.cgi?id=211866&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Looks good -- the only thing i'm really uncomfortable with is the Int48s type -
why do we need this?  I can't see anywhere that you're not explicitly using the
values 1 or 2 and then directly loading indices 0 or 1 - I'm assuming that
there's a templatised function somewhere that you pass these to where it's nice
to just iterate the list but i can't find it :(

Also Int48s seems like an odd name, i'd prefer Int48Tuple or something.  Then
if you wanted you could typedef Int48Pair, etc into existence.