[webkit-reviews] review granted: [Bug 121451] AX: Expose ARIA Busy Notifications : [Attachment 211846] Patch.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Samuel White
<samuel_white at apple.com>'s request for review:
Bug 121451: AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451

Attachment 211846: Patch.
https://bugs.webkit.org/attachment.cgi?id=211846&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211846&action=review


> Source/WebCore/accessibility/AXObjectCache.cpp:834
> +	   postNotification(element, AXObjectCache::AXElementBusyChanged,
true);

The boolean argument to postNotification really makes this code hard to review.
We should change to use an enum instead since we are passing constants to it.
If it was boolean expressions only then it would be fine to keep it a boolean.