[webkit-reviews] review granted: [Bug 121479] Move text caret rect computation to root inline box : [Attachment 211884] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 17 04:20:05 PDT 2013


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 121479: Move text caret rect computation to root inline box
https://bugs.webkit.org/show_bug.cgi?id=121479

Attachment 211884: patch
https://bugs.webkit.org/attachment.cgi?id=211884&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211884&action=review


> Source/WebCore/rendering/RootInlineBox.h:138
> +    IntRect computeCaretRect(float left, unsigned caretWidth, LayoutUnit*
extraWidthToEndOfLine);

Can this be const?


More information about the webkit-reviews mailing list