[webkit-reviews] review granted: [Bug 121310] HashMap should work with move-only keys : [Attachment 211849] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 16 18:19:33 PDT 2013


Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 121310: HashMap should work with move-only keys
https://bugs.webkit.org/show_bug.cgi?id=121310

Attachment 211849: Patch
https://bugs.webkit.org/attachment.cgi?id=211849&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211849&action=review


> Source/WTF/wtf/HashMap.h:428
> -    auto HashMap<T, U, V, W, MappedTraits>::take(const KeyType& key) ->
MappedPassOutType
> +    auto HashMap<T, U, V, W, MappedTraits>::take(const KeyType& key) ->
MappedType

So this doesn’t break callers that expect the return type to be PassRefPtr?


More information about the webkit-reviews mailing list