[webkit-reviews] review granted: [Bug 120069] [MathML] Implement the subscriptshift and superscriptshift attributes : [Attachment 211786] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted gur.trio at gmail.com's request for
review:
Bug 120069: [MathML] Implement the subscriptshift and superscriptshift
attributes
https://bugs.webkit.org/show_bug.cgi?id=120069

Attachment 211786: Patch
https://bugs.webkit.org/attachment.cgi?id=211786&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211786&action=review


> Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:296
> +    LayoutUnit superScriptShiftValue = 0;
> +    LayoutUnit subScriptShiftValue = 0;

superscript and subscript are single words, not pairs of words, so the s in
"script" should not be capitalized

> Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:300
> +    if (m_kind == Sub || m_kind == SubSup || m_kind == Multiscripts)
> +	  
parseMathMLLength(scriptElement->getAttribute(MathMLNames::subscriptshiftAttr),
subScriptShiftValue, style(), false);
> +    if (m_kind == Super || m_kind == SubSup || m_kind == Multiscripts)
> +	  
parseMathMLLength(scriptElement->getAttribute(MathMLNames::superscriptshiftAttr
), superScriptShiftValue, style(), false);

These can both be fastGetAttribute instead of just getAttribute.