[webkit-reviews] review granted: [Bug 121450] MessageQueue should use a Deque of OwnPtrs : [Attachment 211828] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 16 14:02:52 PDT 2013
Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 121450: MessageQueue should use a Deque of OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=121450
Attachment 211828: Patch
https://bugs.webkit.org/attachment.cgi?id=211828&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211828&action=review
> Source/WTF/wtf/MessageQueue.h:197
> + // FIXME: I think the predicate here should really take a const
DataType&
> + // instead of a const OwnPtr<DataType>&.
I agree with this FIXME. Yikes.
More information about the webkit-reviews
mailing list