[webkit-reviews] review granted: [Bug 121382] Web Inspector: TypeError when updating ResourceTreeElement created in strange order : [Attachment 211811] [PATCH] Brian's fix with ChangeLog

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 121382: Web Inspector: TypeError when updating ResourceTreeElement created
in strange order
https://bugs.webkit.org/show_bug.cgi?id=121382

Attachment 211811: [PATCH] Brian's fix with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=211811&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211811&action=review


>>> Source/WebInspectorUI/UserInterface/ResourceTreeElement.js:-175
>>> -	 },
>> 
>> Change log doesn’t mentioned this deletion.
> 
> I guess that is a prepare-ChangeLog issue. This function is unused code that
should have been removed when we switched to "updateStatusForMainFrame".

prepare-ChangeLog has never called out removed functions. That is something you
need to manual do.