[webkit-reviews] review canceled: [Bug 121436] Buildfix in WebResourceBuffer.h to make GCC 4.6 happy : [Attachment 211795] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has canceled Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 121436: Buildfix in WebResourceBuffer.h to make GCC 4.6 happy
https://bugs.webkit.org/show_bug.cgi?id=121436

Attachment 211795: Patch
https://bugs.webkit.org/attachment.cgi?id=211795&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211795&action=review


>> Source/WebKit2/ChangeLog:12
>> +	    actual include because GCC requires a definition of the type for
passing it in a PassOwnPtr.
> 
> That explanation doesn’t make sense. This header doesn’t have any PassOwnPtr.


Good point, it seems it was a typo, not PassOwnPtr, but PassRefPtr.

>> Source/WebKit2/Shared/WebResourceBuffer.h:29
>> +#include "ShareableResource.h"
> 
> Does adding this include to the WebResourceBuffer.cpp file fix the
compilation of that file? I don’t think this is needed in the header.

Thanks the idea, maybe it is enough, I'll check it tomorrow.