[webkit-reviews] review granted: [Bug 121414] [GTK][2.2] Enable the Wayland target by default if the GTK+ Wayland dependency is available : [Attachment 211748] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 121414: [GTK][2.2] Enable the Wayland target by default if the GTK+ Wayland
dependency is available
https://bugs.webkit.org/show_bug.cgi?id=121414

Attachment 211748: Patch
https://bugs.webkit.org/attachment.cgi?id=211748&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211748&action=review


Looks good, but please look into removing the unnecessary temporary variable
before landing.

> Source/autotools/FindDependencies.m4:223
> +    ], [have_gtk_wayland=yes], [have_gtk_wayland=no])
> +    if test "$have_gtk_wayland" = "no"; then
> +	   if test "$with_wayland_target" = "yes"; then
> +	       AC_MSG_ERROR([GTK+ Wayland dependency
(gtk+-wayland-$GTK_API_VERSION >= gtk3_wayland_required_version) not found.])
> +	   else
> +	       AC_MSG_WARN([GTK+ Wayland dependency
(gtk+-wayland-$GTK_API_VERSION >= gtk3_wayland_required_version) not found,
disabling the Wayland target.])
> +	       with_wayland_target=no
> +	   fi
> +    else
> +	   with_wayland_target=yes
> +    fi
>  fi

You don't have to have the temporary variable have_gtk_wayland. Instead you can
put the code you want to execute in the square brackets.