[webkit-reviews] review granted: [Bug 121236] MarkedBlocks shouldn't be put in Allocated state if they didn't produce a FreeList : [Attachment 211592] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 121236: MarkedBlocks shouldn't be put in Allocated state if they didn't
produce a FreeList
https://bugs.webkit.org/show_bug.cgi?id=121236

Attachment 211592: Patch
https://bugs.webkit.org/attachment.cgi?id=211592&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211592&action=review


r=me

> Source/JavaScriptCore/heap/MarkedAllocator.h:135
> +inline void MarkedAllocator::uncanonicalizeCellLivenessData()
> +{
> +    if (!m_canonicalizedBlock)
> +	   return;
> +
> +    m_freeList = m_canonicalizedBlock->uncanonicalizeCellLivenessData();
> +    m_currentBlock = m_canonicalizedBlock;
> +    m_canonicalizedBlock = 0;
> +}

Let's call these functions "stopAllocating" and "resumeAllocating". That way,
we're a little clearer about what's prohibited in this state. Otherwise,
"canonical" doesn't sound like such a bad thing.

> Source/JavaScriptCore/heap/MarkedSpace.h:86
> +    bool iterationInProgress() { return m_currentlyIterating; }

Let's call this "isIterating()" and "m_isIterating".