[webkit-reviews] review denied: [Bug 121315] Inspector Server: queue messages sent before socket connection is established : [Attachment 211576] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 16 10:00:15 PDT 2013
Timothy Hatcher <timothy at apple.com> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 121315: Inspector Server: queue messages sent before socket connection is
established
https://bugs.webkit.org/show_bug.cgi?id=121315
Attachment 211576: Patch
https://bugs.webkit.org/attachment.cgi?id=211576&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211576&action=review
> Source/WebInspectorUI/UserInterface/InspectorFrontendHostStub.js:118
> + remoteConnected: function()
> + {
> + for (i = 0; i < this._messagesQueue.length; i++)
> + WebInspector.socket.send(this._messagesQueue[i]);
> +
> + delete this._messagesQueue;
> + },
> +
> sendMessageToBackend: function(message)
> {
> + // Messages may be sent before the websocket is connected, in
which case
> + // queue them for sending as soon as the connection is
established.
> if (WebInspector.socket)
> WebInspector.socket.send(message);
> + else
> + this._messagesQueue.push(message);
This duplicates a patch I have on bug 121391.
More information about the webkit-reviews
mailing list