[webkit-reviews] review requested: [Bug 121294] [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2 : [Attachment 211804] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 16 09:49:39 PDT 2013


Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 121294: [GTK] socket_embed_hook hitting NULL-check assertion running
TestWebKit2
https://bugs.webkit.org/show_bug.cgi?id=121294

Attachment 211804: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=211804&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
After some discussion on #a11y with other GTK+/GAIL developers (Alejandro
Pinheiro, Benjamin Otte), we seem to agree the right thing to do is to remove
the call to _gtk_accessibility_shutdown() completely, since it made sense in
the times of the atk-bridge being loaded as a module, but it does not anymore.
Check the full IRC log in [1], which has been finally been marked as duplicate
of [2] where a final patch has been proposed and accepted (to commit only after
the freeze).

Hence, I'm proposing now a similar patch here to cope with the issue in
WebKitGTK's internal jhbuild in the meanwhile. Please review.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=708024
[2] https://bugzilla.gnome.org/show_bug.cgi?id=684076


More information about the webkit-reviews mailing list