[webkit-reviews] review canceled: [Bug 97229] Spatial navigation is not working for anchor with inline div with inline img : [Attachment 211443] Updated patch-4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 16 09:06:55 PDT 2013


Abhijeet Kandalkar <kandalkar.abhijeet58 at gmail.com> has canceled Abhijeet
Kandalkar <kandalkar.abhijeet58 at gmail.com>'s request for review:
Bug 97229: Spatial navigation is not working for anchor with inline div with
inline img
https://bugs.webkit.org/show_bug.cgi?id=97229

Attachment 211443: Updated patch-4
https://bugs.webkit.org/attachment.cgi?id=211443&action=review

------- Additional Comments from Abhijeet Kandalkar
<kandalkar.abhijeet58 at gmail.com>
Hi Simon,
I have modified definition of rectToAbsoluteCoordinates() function as per your
comments.
This function returns absolute coordinate of node in main root view.
We can’t remove this function completely as it is called from many places.
So, modifying definition of complete function will bring consistency in Spatial
Navigation code.

I have uploaded working patch. Please let me know your review commnets.


More information about the webkit-reviews mailing list