[webkit-reviews] review granted: [Bug 119387] Remove dependency on CoreFoundation from WebIconDatabase : [Attachment 207910] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 119387: Remove dependency on CoreFoundation from WebIconDatabase
https://bugs.webkit.org/show_bug.cgi?id=119387

Attachment 207910: Patch
https://bugs.webkit.org/attachment.cgi?id=207910&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207910&action=review


Looks fine, but I'd like to try using DEFINE_STATIC_LOCAL instead of the static
initializer.

> Source/WebKit/win/WebIconDatabase.cpp:369
> +    static BSTR iconUserInfoURLKey =
SysAllocString(WebIconNotificationUserInfoURLKey);

Can you change this to be DEFINE_STATIC_LOCAL? We are trying to get rid of
these static initializers where possible.