[webkit-reviews] review granted: [Bug 121378] Shrink factory functions : [Attachment 211693] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 121378: Shrink factory functions
https://bugs.webkit.org/show_bug.cgi?id=121378

Attachment 211693: Patch
https://bugs.webkit.org/attachment.cgi?id=211693&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211693&action=review


r=me

> Source/WebCore/ChangeLog:55
> +	   * html/HTMLElement.cpp:
> +	   (WebCore::populateEventNameForAttributeLocalNameMap): Changed to use
an
> +	   AtomicStringImpl* as the key instead of AtomicString, since all the
strings
> +	   come from the local names of tags, and so don't need to be ref'd.
This saves
> +	   a bit of reference count churn when building the map and is the same
pattern
> +	   used in some maps in the make_names.pl script above.

Clever.

> Source/WebCore/ChangeLog:84
> +	   (WebCore::WebVTTParser::constructTreeFromToken): Pass docuemnt
reference rather than

Typo, document.

> Source/WebCore/dom/make_names.pl:999
> -	   print F "	    if (PassRefPtr<$parameters{namespace}Element>
element = function(qName, document, formElement, createdByParser))\n";
> -	   print F "		return element;\n";
> +	   print F "	    if (RefPtr<$parameters{namespace}Element> element =
function(name, document, formElement, createdByParser))\n";
> +	   print F "		return element.release();\n";

Heh, I resisted telling Sam to make this change just a few hours ago.