[webkit-reviews] review granted: [Bug 121379] Get rid of ref-counting on RenderArena. : [Attachment 211689] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 15 00:51:27 PDT 2013


Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 121379: Get rid of ref-counting on RenderArena.
https://bugs.webkit.org/show_bug.cgi?id=121379

Attachment 211689: Patch
https://bugs.webkit.org/attachment.cgi?id=211689&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211689&action=review


> Source/WebCore/dom/Document.h:1380
> -    RefPtr<RenderArena> m_renderArena;
> +    OwnPtr<RenderArena> m_renderArena;

Maybe just RenderArena would be even better? Maybe not.

> Source/WebCore/rendering/RenderArena.h:46
> +class RenderArena {

Needs noncopyableness. Used to just inherit that from RefCounted.


More information about the webkit-reviews mailing list