[webkit-reviews] review granted: [Bug 120882] MediaStream API: Storing the constraints in MediaStreamSource : [Attachment 211669] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 120882: MediaStream API: Storing the constraints in MediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=120882

Attachment 211669: Patch
https://bugs.webkit.org/attachment.cgi?id=211669&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211669&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests needed.

Please note the Blink revision this was merged from.

> Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:150
> +	   (*iter)->component()->source()->setConstraints(m_audio);
> +
> +
> +    MediaStreamTrackVector videoTracks = stream->getVideoTracks();

Nit: you have an extra blank line here.