[webkit-reviews] review granted: [Bug 121345] CTTE: RenderSVGResourceMarker always has an SVGMarkerElement. : [Attachment 211622] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 121345: CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
https://bugs.webkit.org/show_bug.cgi?id=121345

Attachment 211622: Patch
https://bugs.webkit.org/attachment.cgi?id=211622&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211622&action=review


r=me. I had question about the "renderName" method, but otherwise it looks good
to me.

> Source/WebCore/rendering/svg/RenderSVGResourceMarker.h:38
> +    explicit RenderSVGResourceMarker(SVGMarkerElement&);

Yes!

> Source/WebCore/rendering/svg/RenderSVGResourceMarker.h:-41
> -    virtual const char* renderName() const { return
"RenderSVGResourceMarker"; }

Is this stuff not needed for printing render tree dumps?