[webkit-reviews] review granted: [Bug 121345] CTTE: RenderSVGResourceMarker always has an SVGMarkerElement. : [Attachment 211622] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 13 23:04:08 PDT 2013

Brent Fulgham <bfulgham at webkit.org> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 121345: CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.

Attachment 211622: Patch

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211622&action=review

r=me. I had question about the "renderName" method, but otherwise it looks good
to me.

> Source/WebCore/rendering/svg/RenderSVGResourceMarker.h:38
> +    explicit RenderSVGResourceMarker(SVGMarkerElement&);


> Source/WebCore/rendering/svg/RenderSVGResourceMarker.h:-41
> -    virtual const char* renderName() const { return
"RenderSVGResourceMarker"; }

Is this stuff not needed for printing render tree dumps?

More information about the webkit-reviews mailing list