[webkit-reviews] review granted: [Bug 121336] Replace ScriptState with JSC::ExecState : [Attachment 211610] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 121336: Replace ScriptState with JSC::ExecState
https://bugs.webkit.org/show_bug.cgi?id=121336

Attachment 211610: Patch
https://bugs.webkit.org/attachment.cgi?id=211610&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211610&action=review


> Source/WebCore/dom/Document.cpp:862
> +PassRefPtr<CustomElementConstructor>
Document::registerElement(WebCore::JSC::ExecState* state, const AtomicString&
name, ExceptionCode& ec)

WebCore::JSC? No!

> Source/WebCore/dom/Document.cpp:867
> +PassRefPtr<CustomElementConstructor>
Document::registerElement(WebCore::JSC::ExecState* state, const AtomicString&
name, const Dictionary& options, ExceptionCode& ec)

Ditto.

> Source/WebCore/dom/Document.h:1142
> +    PassRefPtr<CustomElementConstructor>
registerElement(WebCore::JSC::ExecState*, const AtomicString& name,
ExceptionCode&);
> +    PassRefPtr<CustomElementConstructor>
registerElement(WebCore::JSC::ExecState*, const AtomicString& name, const
Dictionary& options, ExceptionCode&);

WebCore::JSC? No!