[webkit-reviews] review granted: [Bug 121336] Replace ScriptState with JSC::ExecState : [Attachment 211609] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 121336: Replace ScriptState with JSC::ExecState
https://bugs.webkit.org/show_bug.cgi?id=121336

Attachment 211609: Patch
https://bugs.webkit.org/attachment.cgi?id=211609&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211609&action=review


>> Source/WebCore/bindings/js/ScriptProfiler.h:62
>> +	static void start(JSC::ExecState* state, const String& title);
> 
> The parameter name "state" adds no information, so it should be removed. 
[readability/parameter_name] [5]

Yes please.

>> Source/WebCore/bindings/js/ScriptProfiler.h:67
>> +	static PassRefPtr<ScriptProfile> stop(JSC::ExecState* state, const
String& title);
> 
> The parameter name "state" adds no information, so it should be removed. 
[readability/parameter_name] [5]

Ditto.