[webkit-reviews] review granted: [Bug 121323] Make FloatingObjects own it's FloatingObject instances : [Attachment 211598] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 121323: Make FloatingObjects own it's FloatingObject instances
https://bugs.webkit.org/show_bug.cgi?id=121323

Attachment 211598: Patch
https://bugs.webkit.org/attachment.cgi?id=211598&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211598&action=review


Looks good. Thanks!

> Source/WebCore/rendering/FloatingObjects.cpp:174
> +void FloatingObjects::exportToFloatInfoMap(RendererToFloatInfoMap& map)

nit: The function name is confusing as it doesn't say it is releasing the
ownership of its own content.

> Source/WebCore/rendering/RenderBlock.cpp:3307
> +    m_floatingObjects->add(newObj.release());

nit: Might be usefull to make "add" return a pointer to the floating object to
avoid the manual store on the stack.