[webkit-reviews] review requested: [Bug 114209] Flaky Test: http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html : [Attachment 211584] skip the test

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 114209: Flaky Test:
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
https://bugs.webkit.org/show_bug.cgi?id=114209

Attachment 211584: skip the test
https://bugs.webkit.org/attachment.cgi?id=211584&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This functionality is hopelessly broken in deprecated web inspector. The test
intends to check application cache events in the case when the cache fails to
download, but front-end doesn't track cache status at all until the document
has an associated cache. So when the test passes, it's accidental.

ApplicationCacheModel._frameManifestUpdated just bails out if manifest URL is
empty, so status remains 0 even while download is in progress.

Initially, the test correctly waited for the state to become DOWNLOADING, and
then to become UNCACHED again. But <http://trac.webkit.org/changeset/100454>
dumbed it down, presumably to cover a bug introduced in that revision (there is
no explanation in ChangeLog, which pretends that the file was moved unchanged).


Keeping the test around in case it could serve as a reminder to write a similar
one for new front-end.