[webkit-reviews] review granted: [Bug 121307] [Windows] Activate FastMalloc hardening on Windows : [Attachment 211563] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 121307: [Windows] Activate FastMalloc hardening on Windows
https://bugs.webkit.org/show_bug.cgi?id=121307

Attachment 211563: Patch
https://bugs.webkit.org/attachment.cgi?id=211563&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211563&action=review


r=me with comments

> Source/WTF/wtf/FastMalloc.cpp:110
> +#if (COMPILER(GCC) || COMPILER(MSVC)) && !PLATFORM(QT)

maybe we can just try !PLATFORM(QT) and see what happens?

> Source/WTF/wtf/FastMalloc.cpp:840
> +#if COMPILER(MSVC)
> +    void* tValNext = *(reinterpret_cast<void**>(t.value())); // FIXME: This
exists to work around a MSVC bug
> +    return HardenedSLL::create(XOR_MASK_PTR_WITH_KEY(tValNext, t.value(),
entropy));
> +#else
>      return
HardenedSLL::create(XOR_MASK_PTR_WITH_KEY(*(reinterpret_cast<void**>(t.value())
), t.value(), entropy));
> +#endif

Remove the #if MSVC and just always use that path.  It's conceivable that it's
a "legitimate" piece of behaviour and it really shouldn't hurt.