[webkit-reviews] review granted: [Bug 121279] Finish removing layer-violating code from Pasteboard (just for Mac during this first step) : [Attachment 211516] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 13 07:59:20 PDT 2013


Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 121279: Finish removing layer-violating code from Pasteboard (just for Mac
during this first step)
https://bugs.webkit.org/show_bug.cgi?id=121279

Attachment 211516: Patch
https://bugs.webkit.org/attachment.cgi?id=211516&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211516&action=review


> Source/WebCore/editing/mac/EditorMac.mm:538
> +    String uniqueIDString = adoptCF(CFUUIDCreateString(nullptr,
adoptCF(CFUUIDCreate(nullptr)).get())).get();

I think we have our own UUID implementation in WTF if you do't like all the
.gets here.

I also think you should use kCFAllocatorDefault instead of nullptr.


More information about the webkit-reviews mailing list