[webkit-reviews] review granted: [Bug 107101] [EFL][WK2] Implement pan and flick gesture. : [Attachment 211524] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 107101: [EFL][WK2] Implement pan and flick gesture.
https://bugs.webkit.org/show_bug.cgi?id=107101

Attachment 211524: Patch
https://bugs.webkit.org/attachment.cgi?id=211524&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211524&action=review


It looks there is no big issue as well.

> Source/WebKit2/UIProcess/API/efl/GestureRecognizer.cpp:181
> +	   const HistoryItem& firstHistoryItem =
m_history[m_oldestHistoryItemIndex];

> Until this moment, the m_firstHistoryItemIndex is 0, and I can get "10". "60"
is added to the history, the m_history can be [60, 20, 30, 40, 50], and
m_firstHistoryItemIndex is 1 and the vaule is "20".

Thank you for your explanation. Don't you need to change *firstHistoryItem*
with *oldestHistoryItem* as well?