[webkit-reviews] review denied: [Bug 121283] [CTTE] Tighter element types for RenderSVGInline and subclasses. : [Attachment 211521] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 13 02:18:19 PDT 2013
Antti Koivisto <koivisto at iki.fi> has denied review:
Bug 121283: [CTTE] Tighter element types for RenderSVGInline and subclasses.
https://bugs.webkit.org/show_bug.cgi?id=121283
Attachment 211521: Patch
https://bugs.webkit.org/attachment.cgi?id=211521&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=211521&action=review
> Source/WebCore/rendering/svg/RenderSVGTSpan.h:37
> + SVGTextPositioningElement& textPositioningElement() const { return
static_cast<SVGTextPositioningElement&>(*RenderObject::node()); }
please call the closest base class function instead of node()
More information about the webkit-reviews
mailing list