[webkit-reviews] review granted: [Bug 121278] [CTTE] RenderFileUploadControl always has a HTMLInputElement. : [Attachment 211514] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 13 00:54:38 PDT 2013
Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 121278: [CTTE] RenderFileUploadControl always has a HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=121278
Attachment 211514: Patch
https://bugs.webkit.org/attachment.cgi?id=211514&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211514&action=review
> Source/WebCore/rendering/RenderFileUploadControl.h:47
> + virtual bool isFileUploadControl() const OVERRIDE { return true; }
We don’t have to shout OVERRIDE any more. Apparently we do need to yell when
saying FINAL, though.
More information about the webkit-reviews
mailing list