[webkit-reviews] review granted: [Bug 121263] Move LineLayoutState class to LineLayoutState.h : [Attachment 211481] proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 121263: Move LineLayoutState class to LineLayoutState.h
https://bugs.webkit.org/show_bug.cgi?id=121263

Attachment 211481: proposed patch
https://bugs.webkit.org/attachment.cgi?id=211481&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211481&action=review


> Source/WebCore/rendering/LineLayoutState.h:125
> +    Vector<RenderBlock::FloatWithRect> m_floats;
> +    FloatingObject* m_lastFloat;
> +    RootInlineBox* m_endLine;
> +    LineInfo m_lineInfo;
> +    unsigned m_floatIndex;
> +    LayoutUnit m_endLineLogicalTop;
> +    bool m_endLineMatched;
> +    bool m_checkForFloatsFromLastLine;
> +
> +    bool m_isFullLayout;
> +
> +    // FIXME: Should this be a range object instead of two ints?
> +    LayoutUnit& m_repaintLogicalTop;
> +    LayoutUnit& m_repaintLogicalBottom;
> +
> +    LayoutUnit m_adjustedLogicalLineTop;
> +
> +    bool m_usesRepaintBounds;
> +
> +    RenderFlowThread* m_flowThread;

While we're at it, can we reorder these member variables to match the ordering
of member functions?
Also, can we make bools packed with bit fields?