[webkit-reviews] review denied: [Bug 121259] [GTK] Do not enable VIDEO_TRACK if VIDEO is disabled : [Attachment 211476] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 12 15:02:39 PDT 2013


Martin Robinson <mrobinson at webkit.org> has denied Alberto Garcia
<berto at igalia.com>'s request for review:
Bug 121259: [GTK] Do not enable VIDEO_TRACK if VIDEO is disabled
https://bugs.webkit.org/show_bug.cgi?id=121259

Attachment 211476: Patch
https://bugs.webkit.org/attachment.cgi?id=211476&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
Apologies for how confusing the interaction of build-webkit and configure is,
but the features defined in SetupWebKitFeatures.m4 describe the setup for
release builds. We do not want to enable video track yet for release builds, so
this patch isn't really correct. Furthermore, WebKitFeatureOverrides.txt should
override any value you use here, I'm not sure it works.


More information about the webkit-reviews mailing list