[webkit-reviews] review denied: [Bug 121224] Support having scrollbars on the left in right-to-left layout : [Attachment 211420] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 12 12:56:04 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 121224: Support having scrollbars on the left in right-to-left layout
https://bugs.webkit.org/show_bug.cgi?id=121224

Attachment 211420: Patch
https://bugs.webkit.org/attachment.cgi?id=211420&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211420&action=review


> Source/WebCore/platform/ScrollView.h:141
> +    bool reverseLayout() const;
> +    void setReverseLayout(bool);

I think we need a better term than "reverseLayout", for several reasons:
1. We use layout() as a verb with a specific meaning
2. Unclear what "reverse" means. Does it put the horizontal scrollbar at the
top?

Maybe scrollbarOnLeft()?


More information about the webkit-reviews mailing list