[webkit-reviews] review granted: [Bug 121238] Bitmap's WordType should be a template parameter : [Attachment 211449] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 12 12:35:16 PDT 2013


Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 121238: Bitmap's WordType should be a template parameter
https://bugs.webkit.org/show_bug.cgi?id=121238

Attachment 211449: Patch
https://bugs.webkit.org/attachment.cgi?id=211449&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211449&action=review


> Source/WTF/ChangeLog:26
> +	   (WTF::::Bitmap):
> +	   (WTF::::get):
> +	   (WTF::::set):
> +	   (WTF::::testAndSet):
> +	   (WTF::::testAndClear):
> +	   (WTF::::concurrentTestAndSet):
> +	   (WTF::::concurrentTestAndClear):
> +	   (WTF::::clear):
> +	   (WTF::::clearAll):
> +	   (WTF::::nextPossiblyUnset):
> +	   (WTF::::findRunOfZeros):
> +	   (WTF::::count):
> +	   (WTF::::isEmpty):
> +	   (WTF::::isFull):

The prepare-ChangeLog script made a mess here. I suggest inserting the class
name Bitmap into these function names.


More information about the webkit-reviews mailing list