[webkit-reviews] review granted: [Bug 121236] MarkedBlocks shouldn't be put in Allocated state if they didn't produce a FreeList : [Attachment 211442] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 12 11:05:31 PDT 2013
Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 121236: MarkedBlocks shouldn't be put in Allocated state if they didn't
produce a FreeList
https://bugs.webkit.org/show_bug.cgi?id=121236
Attachment 211442: Patch
https://bugs.webkit.org/attachment.cgi?id=211442&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211442&action=review
r=me
> Source/JavaScriptCore/heap/MarkedAllocator.cpp:42
> + block->didSweepButToNoAvail();
How about "didConsumeEmptyFreeList"? ("No avail" doesn't specify what you were
trying to avail yourself of.)
More information about the webkit-reviews
mailing list