[webkit-reviews] review granted: [Bug 121230] SharedBuffer::createCFData should return RetainPtr<CFDataRef> : [Attachment 211436] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 121230: SharedBuffer::createCFData should return RetainPtr<CFDataRef>
https://bugs.webkit.org/show_bug.cgi?id=121230

Attachment 211436: Patch
https://bugs.webkit.org/attachment.cgi?id=211436&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211436&action=review


> Source/WebCore/platform/mac/SharedBufferMac.mm:109
> +    return adoptCF((CFDataRef)adoptNS([[WebCoreSharedBufferData alloc]
initWithSharedBuffer:this]).leakRef());

We’ve got to find a better idiom for toll free bridging with RetainPtr than
this. It destroys the rule of “look for leakRef” to find bugs.