[webkit-reviews] review granted: [Bug 121214] Keep sourceID and position info in DebuggerCallFrame instead of the Inspector's JavaScriptCallFrame : [Attachment 211403] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 121214: Keep sourceID and position info in DebuggerCallFrame instead of the
Inspector's JavaScriptCallFrame
https://bugs.webkit.org/show_bug.cgi?id=121214

Attachment 211403: the patch.
https://bugs.webkit.org/attachment.cgi?id=211403&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211403&action=review


r=me

> Source/JavaScriptCore/interpreter/Interpreter.cpp:659
> +	   DebuggerCallFrame debuggerCallFrame(callFrame, line, 0,
exceptionValue);

Why not provide a real column number here?