[webkit-reviews] review granted: [Bug 121075] Move layering-violating code from Pasteboard::plainText into Editor (Mac only at first) : [Attachment 211427] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 121075: Move layering-violating code from Pasteboard::plainText into Editor
(Mac only at first)
https://bugs.webkit.org/show_bug.cgi?id=121075

Attachment 211427: Patch
https://bugs.webkit.org/attachment.cgi?id=211427&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211427&action=review


> Source/WebCore/platform/mac/PasteboardMac.mm:297
> +	       if (RetainPtr<NSAttributedString> attributedString =
[[NSAttributedString alloc] initWithRTF:[data->createNSData() autorelease]
documentAttributes:NULL]) {

Missing an adoptNS here! Also, i'd use auto instead of repeating the type twice
here.