[webkit-reviews] review granted: [Bug 117281] Crash in V8 benchmarks set in ARM, softfp, EABI : [Attachment 211401] omit_arg1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 12 08:24:15 PDT 2013


Michael Saboff <msaboff at apple.com> has granted Youngho Yoo
<youngho33.yoo at lge.com>'s request for review:
Bug 117281: Crash in V8 benchmarks set in ARM,softfp,EABI
https://bugs.webkit.org/show_bug.cgi?id=117281

Attachment 211401: omit_arg1
https://bugs.webkit.org/attachment.cgi?id=211401&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211401&action=review


r=me with suggested empty line format changes.

Sorry it took so long to get this reviewed.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1260
> +    }

Add an empty line below this method.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1291
>      }

Put the empty line below this method back in.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1498
> +    }

Add an empty line below this method.


More information about the webkit-reviews mailing list