[webkit-reviews] review granted: [Bug 121213] [CSS Shapes] Remove unnecessarily complex template from ShapeInfo classes : [Attachment 211400] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 121213: [CSS Shapes] Remove unnecessarily complex template from ShapeInfo
classes
https://bugs.webkit.org/show_bug.cgi?id=121213

Attachment 211400: Patch
https://bugs.webkit.org/attachment.cgi?id=211400&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211400&action=review


> Source/WebCore/rendering/shapes/ShapeInfo.h:113
> +    virtual ShapeValue* getShapeValue() const = 0;

In WebKit coding style, functions like this one are supposed to be named just
"shapeValue()" without the get prefix.

> Source/WebCore/rendering/shapes/ShapeInsideInfo.h:65
> +class ShapeInsideInfo : public ShapeInfo<RenderBlock> {

Can this class be marked FINAL?

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.h:42
> +class ShapeOutsideInfo : public ShapeInfo<RenderBox>, public
MappedInfo<RenderBox, ShapeOutsideInfo> {

Can this class be marked FINAL?