[webkit-reviews] review granted: [Bug 121194] Removed some unused functions from the debugger interface : [Attachment 211387] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 11 19:40:39 PDT 2013


Joseph Pecoraro <joepeck at webkit.org> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 121194: Removed some unused functions from the debugger interface
https://bugs.webkit.org/show_bug.cgi?id=121194

Attachment 211387: Patch
https://bugs.webkit.org/attachment.cgi?id=211387&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211387&action=review


r=me

> Source/WebCore/inspector/InjectedScriptSource.js:-692
> -	       setter =
InjectedScriptHost.setFunctionVariableValue.bind(InjectedScriptHost, func); 

This is the only user of InjectedScriptHost.setFunctionVariableValue.bind. It
is equally stubbed so you can remove that too!

  - WebCore/bindings/js/JSInjectedScriptHostCustom.cpp stub
  - WebCore/inspector/InjectedScriptExterns.js stub
  - WebCore/inspector/InjectedScriptHost.idl [Custom]


More information about the webkit-reviews mailing list